AHeise commented on a change in pull request #10460: [FLINK-14574] Fixing 
writing with plugin s3 filesystem. 
URL: https://github.com/apache/flink/pull/10460#discussion_r355119323
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_batch_wordcount.sh
 ##########
 @@ -52,13 +78,11 @@ case $INPUT_TYPE in
     ;;
 esac
 
-OUTPUT_LOCATION="${TEST_DATA_DIR}/out/wc_out"
-
-mkdir -p "${TEST_DATA_DIR}"
-
+mkdir -p "$(dirname $OUTPUT_PATH)"
 start_cluster
 
 # The test may run against different source types.
 # But the sources should provide the same test data, so the checksum stays the 
same for all tests.
-eval "${FLINK_DIR}/bin/flink run -p 1 
${FLINK_DIR}/examples/batch/WordCount.jar ${INPUT_ARGS} --output 
${OUTPUT_LOCATION}"
-check_result_hash "WordCount (${INPUT_TYPE})" "${OUTPUT_LOCATION}" 
"${RESULT_HASH}"
+${FLINK_DIR}/bin/flink run -p 1 ${FLINK_DIR}/examples/batch/WordCount.jar 
${ARGS}
+${fetch_complete_result[@]}
 
 Review comment:
   Added a comment `# Fetches result from AWS s3 to the OUTPUT_PATH, no-op for 
other filesystems and minio-based tests`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to