zjffdu commented on a change in pull request #10475:
[FLINK-15118][FLINK-15119][FLINK-15120] Make flink-scala-shell use Executors
URL: https://github.com/apache/flink/pull/10475#discussion_r355119701
##########
File path:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
##########
@@ -221,41 +185,59 @@ object FlinkShell {
repl.process(settings)
} finally {
repl.closeInterpreter()
- cluster match {
- case Some(Left(miniCluster)) => miniCluster.close()
- case Some(Right(yarnCluster)) =>
- yarnCluster.shutDownCluster()
- yarnCluster.close()
+ clusterClient match {
+ case Some(clusterClient) =>
+ clusterClient.shutDownCluster()
+ clusterClient.close()
case _ =>
}
}
println(" good bye ..")
}
- def deployNewYarnCluster(
- configuration: Configuration,
- configurationDirectory: String,
- yarnConfig: YarnConfig) = {
+ private def fetchConnectionInfo(config: Config, flinkConfig: Configuration)
= {
Review comment:
It's better to specify the return type explicitly for readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
