aljoscha commented on issue #10474: [FLINK-15116] Make JobClient stateless, remove AutoCloseable URL: https://github.com/apache/flink/pull/10474#issuecomment-562866568 @zjffdu I think that in the long run we might need a more general `FlinkClient` that also allows cluster operations and listing jobs, but unfortunately we don't have that right now and we're running a bit out of time for Flink 1.10. @TisonKun & @zjffdu What do you think about the changes in this PR? I think it's a general improvement, because it solves the problem of the `JobClient` "leaking", that is, if the user simply calls `executeAsync()` and ignores the result the `JobClient` would never be closed. Regarding the shutdown hook, I have another commit that re-introduces the removal of the hook but places the hook not in the executor but in the execution environment, this also fixes another problem with the hook. I have a long description in the commit that I will push soon once I'm happy with it. Then you will understand.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
