godfreyhe commented on issue #10480: [FLINK-15095] [table-planner-blink] bridge 
table schema's primary key to metadata handler in blink planner
URL: https://github.com/apache/flink/pull/10480#issuecomment-562907363
 
 
   > In `FlinkPreparingTableBase`, we override the `boolean 
isKey(ImmutableBitSet columns)` method and always return `false`. Should this 
also be modified?
   
   currently, blink planner and calcite does not use `isKey` method to tell 
whether the given columns are a key or a superset of a unique key. A new public 
method named `uniqueKeysSet` in `FlinkPreparingTableBase` is used to return 
unique keys for metadata handler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to