zhuzhurk commented on a change in pull request #10245: 
[FLINK-10936][kubernetes] Implement Kubernetes command line tools to support 
session cluster.
URL: https://github.com/apache/flink/pull/10245#discussion_r355160547
 
 

 ##########
 File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java
 ##########
 @@ -42,6 +47,8 @@
  */
 public abstract class AbstractCustomCommandLine implements CustomCommandLine {
 
+       private static final Logger LOG = 
LoggerFactory.getLogger(AbstractCustomCommandLine.class);
 
 Review comment:
   Maybe we can make this logger `protected final Logger LOG = 
LoggerFactory.getLogger(getClass());` for all its sub classes to use, so that 
we do not need to create multiple loggers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to