StephanEwen commented on a change in pull request #10483:
[FLINK-15099][runtime] (FLIP-27) Add Operator Coordinators and Events
URL: https://github.com/apache/flink/pull/10483#discussion_r355182248
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -291,6 +297,7 @@ public Task(
TaskManagerActions taskManagerActions,
InputSplitProvider inputSplitProvider,
CheckpointResponder checkpointResponder,
+ OperatorEventSender operatorCoordinatorEventGateway,
Review comment:
I was thinking about that as well. The reason is that each layer adds
information. Within the operator, you just throw out events. In the
StreamTask, this gets augmented with Operator ID and in the Task with Task
Execution Attempt Id. I wanted to avoid that the operator has to think about
the context it runs in, hence these layers.
I can try and align the names, at lease `OperatorEventGateway` -->
`TaskOperatorEventGateway` --> `TaskExecutorOperatorEventGateway`.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
