lirui-apache commented on a change in pull request #10381: [FLINK-14513][hive]
Implement listPartitionsByFilter to HiveCatalog
URL: https://github.com/apache/flink/pull/10381#discussion_r355195591
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -126,7 +127,7 @@ public boolean isBounded() {
@Override
public DataStream<BaseRow> getDataStream(StreamExecutionEnvironment
execEnv) {
if (!initAllPartitions) {
- initAllPartitions();
+ initAllPartitions(null);
Review comment:
Do you mean we should only compute `allHivePartitions` here and not
`partitionSpec2HiveTablePartition`? It might be a valid improvement but doesn't
seem to be directly related to the goal of this PR. Besides, if we somehow
firstly call `HiveTableSource::getDataStream ` and then call
`HiveTableSource::applyPartitionPruning`, we may end up not computing
`partitionSpec2HiveTablePartition` at all. Let's figure this out in a follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
