TisonKun commented on a change in pull request #10489: [FLINK-15134][client] 
Delete temporary files created in YarnClusterDescriptor
URL: https://github.com/apache/flink/pull/10489#discussion_r355247768
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -867,27 +870,28 @@ private ApplicationReport startAppMaster(
                                TaskManagerOptions.TOTAL_PROCESS_MEMORY,
                                clusterSpecification.getTaskManagerMemoryMB() + 
"m");
 
-               // Upload the flink configuration
-               // write out configuration file
-               File tmpConfigurationFile = File.createTempFile(appId + 
"-flink-conf.yaml", null);
-               tmpConfigurationFile.deleteOnExit();
-               BootstrapTools.writeConfiguration(configuration, 
tmpConfigurationFile);
+               {
+                       // Upload the flink configuration
+                       // write out configuration file
+                       File tmpConfigurationFile = File.createTempFile(appId + 
"-flink-conf.yaml", null);
+                       tmpConfigurationFile.deleteOnExit();
 
 Review comment:
   Make sense. I force push a new commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to