JingsongLi commented on a change in pull request #10381: [FLINK-14513][hive]
Implement listPartitionsByFilter to HiveCatalog
URL: https://github.com/apache/flink/pull/10381#discussion_r355248685
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -126,7 +127,7 @@ public boolean isBounded() {
@Override
public DataStream<BaseRow> getDataStream(StreamExecutionEnvironment
execEnv) {
if (!initAllPartitions) {
- initAllPartitions();
+ initAllPartitions(null);
Review comment:
I prefer do this little refactor. Because we don't need
`partitionSpec2HiveTablePartition`. There is a little confuse about
`initAllPartitions`.
There is no reason to get partition details except in `getDataStream`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
