zhijiangW commented on a change in pull request #10492: [FLINK-15140][runtime]
Fix shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492#discussion_r355313454
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/runtime/ShuffleCompressionITCase.java
##########
@@ -133,18 +136,19 @@ public LongValueSource(Environment environment) {
@Override
public void invoke() throws Exception {
ResultPartitionWriter resultPartitionWriter =
getEnvironment().getWriter(0);
- RecordWriterBuilder<LongValue> recordWriterBuilder =
new RecordWriterBuilder<>();
+ RecordWriterBuilder<LongValue> recordWriterBuilder =
new RecordWriterBuilder<>()
+ .setChannelSelector(new BroadcastPartitioner());
Review comment:
It might be better to give two cases for covering both broadcast and
non-broadcast
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
