zjffdu commented on issue #10479: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10479#issuecomment-563141780 I have rebased this PR and it is ready for review @aljoscha @kl0u @TisonKun 2 main changes: 1. return `JobClient` for `executeAsync` instead of `CompletableFuture<JobClient>`. To me, the semantic of executeAsync means to submit the job and return without waiting for it to be completed. If we return `CompletableFuture<JobClient>`, the method name should be `submitAsync` which I don't think is what user want. 2. I also made some changes in FlinkShell (It is affected by ticket FLINK-15118). I use it internally in Zeppelin to create and shutdown cluster and also obtain the ClusterClient. Before we have general `FlinkClient` could we just keep them public as before ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
