kl0u commented on issue #10491: [FLINK-15093][streaming-java] 
StreamExecutionEnvironment does not cle…
URL: https://github.com/apache/flink/pull/10491#issuecomment-563210011
 
 
   You can also remove all the `transformation.clear();` calls from the 
subclasses of the `StreamExecutionEnvironment`. These are 
`RemoteStreamEnvironment`, `StreamContextEnvironment`, 
`LocalStreamEnvironment`, `StreamPlanEnvironment`. 
   
   After changing this, the `LocalStreamEnvironment.execute()` I think it can 
go away as it will only call the `super.execute()`. The same could be done for 
the `RemoteStreamEnvironment`, but there the exception message and type will 
change in some cases. Personally I am ok with that. 
   
   What do you think @danny0405 and @aljoscha ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to