TisonKun commented on a change in pull request #10434: [FLINK-15072][client] 
Hijack executeAsync instead of execute in context environment
URL: https://github.com/apache/flink/pull/10434#discussion_r355959300
 
 

 ##########
 File path: 
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
 ##########
 @@ -91,25 +84,35 @@ public JobExecutionResult execute(String jobName) throws 
Exception {
                        }
 
                        jobExecutionResult = jobExecutionResultFuture.get();
 
 Review comment:
   @aljoscha I notice that we don't callback job listener if context 
environment calls...we don't call `super.execute` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to