Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1343#discussion_r44397599
--- Diff: tools/maven/checkstyle.xml ---
@@ -54,11 +54,18 @@ under the License.
<module name="IllegalImport">
<property name="illegalPkgs"
value="org.apache.flink.shaded"/>
</module>
+ <!-- forbid use of commons lang validate -->
<module name="Regexp">
<property name="format"
value="org\.apache\.commons\.lang3\.Validate"/>
<property name="illegalPattern" value="true"/>
<property name="message" value="Use Guava Checks
instead of Commons Validate. Please refer to the coding guidelines."/>
</module>
+ <!-- forbid the use of
org.apache.commons.lang.SerializationUtils -->
+ <module name="Regexp">
+ <property name="format"
value="org\.apache\.commons\.lang\.SerializationUtils"/>
+ <property name="illegalPattern" value="true"/>
+ <property name="message" value="Use Flink's
InstantiationUtil instead of common's SerializationUtils"/>
+ </module>
<module name="NeedBraces">
--- End diff --
Big :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
