sjwiesman commented on a change in pull request #10515: [FLINK-14007][python][docs] Add documentation for how to use Java user-defined source/sink in Python API URL: https://github.com/apache/flink/pull/10515#discussion_r356140511
########## File path: docs/dev/table/sourceSinks.md ########## @@ -714,10 +714,11 @@ connector.debug=true For a type-safe, programmatic approach with explanatory Scaladoc/Javadoc, the Table & SQL API offers descriptors in `org.apache.flink.table.descriptors` that translate into string-based properties. See the [built-in descriptors](connect.html) for sources, sinks, and formats as a reference. -A connector for `MySystem` in our example can extend `ConnectorDescriptor` as shown below: - <div class="codetabs" markdown="1"> <div data-lang="java" markdown="1"> + +A connector for `MySystem` in our example can extend `ConnectorDescriptor` as shown below: Review comment: This isn't exactly true, the class MySystem doesn't extend ConnectorDescriptor. What about: > A custom descriptor can be defined by implementing the `ConnectorDescriptor` interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
