[
https://issues.apache.org/jira/browse/FLINK-15175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993155#comment-16993155
]
liupengcheng commented on FLINK-15175:
--------------------------------------
Thanks for reply, [~ykt836] [~lzljs3620320], Can you assign this Jira to me, I
will create a pull request later.
I think the fast fix is easy, we can just update the regex expression for
SELECT in SQL CLI command parser, but I'm a little worried that this kind of
fix is not complete, there might be some sql still left unsupported.
How about extending calcite core parser in flink to support DDL and more sql
syntax, thus can make the parser unified, the SQL CLI just manage it's own
customized command(e.g. QUIT), and passing all other sql to the planner
directly.
> syntax not supported in SQLClient for TPCDS queries
> ----------------------------------------------------
>
> Key: FLINK-15175
> URL: https://issues.apache.org/jira/browse/FLINK-15175
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Client
> Affects Versions: 1.10.0
> Reporter: liupengcheng
> Priority: Major
>
> {code:java}
> Flink SQL> WITH customer_total_return AS
> > ( SELECT
> > sr_customer_sk AS ctr_customer_sk,
> > sr_store_sk AS ctr_store_sk,
> > sum(sr_return_amt) AS ctr_total_return
> > FROM store_returns, date_dim
> > WHERE sr_returned_date_sk = d_date_sk AND d_year = 2000
> > GROUP BY sr_customer_sk, sr_store_sk)
> > SELECT c_customer_id
> > FROM customer_total_return ctr1, store, customer
> > WHERE ctr1.ctr_total_return >
> > (SELECT avg(ctr_total_return) * 1.2
> > FROM customer_total_return ctr2
> > WHERE ctr1.ctr_store_sk = ctr2.ctr_store_sk)
> > AND s_store_sk = ctr1.ctr_store_sk
> > AND s_state = 'TN'
> > AND ctr1.ctr_customer_sk = c_customer_sk
> > ORDER BY c_customer_id
> > LIMIT 100;
> [ERROR] Unknown or invalid SQL statement.
> {code}
> It seems that the newest branch already support all TPCDS queries, but
> currently the sql client parser has not supported yet.
> Anyone already working on this? If not I can try it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
