wuchong commented on a change in pull request #10518: [FLINK-15124][table] Fix
types with precision defined in DDL can't be executed
URL: https://github.com/apache/flink/pull/10518#discussion_r356392549
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/sources/TableSourceUtil.scala
##########
@@ -18,31 +18,27 @@
package org.apache.flink.table.planner.sources
-import org.apache.flink.api.common.typeinfo.TypeInformation
-import org.apache.flink.api.common.typeutils.CompositeType
import org.apache.flink.table.api.{DataTypes, TableSchema,
ValidationException, WatermarkSpec}
import
org.apache.flink.table.expressions.utils.ApiExpressionUtils.{typeLiteral,
valueLiteral}
import org.apache.flink.table.expressions.{CallExpression, ResolvedExpression,
ResolvedFieldReference}
import org.apache.flink.table.functions.BuiltInFunctionDefinitions
import org.apache.flink.table.planner.calcite.FlinkTypeFactory
import org.apache.flink.table.planner.expressions.converter.ExpressionConverter
-import org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter
-import org.apache.flink.table.runtime.types.PlannerTypeUtils.isAssignable
-import
org.apache.flink.table.runtime.types.TypeInfoDataTypeConverter.fromDataTypeToTypeInfo
-import
org.apache.flink.table.runtime.types.TypeInfoLogicalTypeConverter.fromTypeInfoToLogicalType
+import org.apache.flink.table.runtime.types.{LogicalTypeDataTypeConverter,
TypeInfoLogicalTypeConverter}
+import org.apache.flink.table.runtime.types.PlannerTypeUtils.{isAssignable,
isInteroperable}
+import
org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
+import
org.apache.flink.table.runtime.types.TypeInfoLogicalTypeConverter.fromLogicalTypeToTypeInfo
import org.apache.flink.table.sources.{DefinedFieldMapping,
DefinedProctimeAttribute, DefinedRowtimeAttributes, RowtimeAttributeDescriptor,
TableSource}
import org.apache.flink.table.types.DataType
-import org.apache.flink.table.types.logical.{LogicalType, TimestampKind,
TimestampType, TinyIntType}
+import org.apache.flink.table.types.logical.{LogicalType, LogicalTypeRoot,
RowType, TimestampKind, TimestampType, TinyIntType}
import org.apache.flink.table.typeutils.TimeIndicatorTypeInfo
-
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
