[
https://issues.apache.org/jira/browse/FLINK-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993178#comment-16993178
]
Jingsong Lee commented on FLINK-14364:
--------------------------------------
Hi [~wind_ljy], current status is we can only setAllowComments(true) when
setIgnoreParseErrors(true).
As you said, we should add this into #CsvValidator#validate. I think we can do
it in this way to improve usability.
Consider this ticket is usability improve, I will change it to 1.11.
> Allow comments fail when not ignore parse errors in
> CsvRowDeserializationSchema
> -------------------------------------------------------------------------------
>
> Key: FLINK-14364
> URL: https://issues.apache.org/jira/browse/FLINK-14364
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
> Reporter: Jingsong Lee
> Assignee: Jiayi Liao
> Priority: Major
> Fix For: 1.10.0
>
>
> Use CsvRowDeserializationSchema, when setIgnoreParseErrors(false) and
> setAllowComments(true).
> If there are some comments in msg, will throw MismatchedInputException.
> If this a bug? and we should catch MismatchedInputException and return null?
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
