JingsongLi commented on a change in pull request #10514:
[FLINK-15167][sql-client] SQL CLI library option doesn't work for Hive connector
URL: https://github.com/apache/flink/pull/10514#discussion_r356412063
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -337,6 +342,11 @@ private Module createModule(Map<String, String>
moduleProperties, ClassLoader cl
return factory.createModule(moduleProperties);
}
+ private void createAndRegisterCatalog(String name, CatalogEntry entry) {
+ Catalog catalog = createCatalog(name, entry.asMap(),
Thread.currentThread().getContextClassLoader());
Review comment:
Why `Thread.currentThread().getContextClassLoader()` instead of class member
`classLoader`?
The only thing you need is `wrapClassLoader`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
