[
https://issues.apache.org/jira/browse/FLINK-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998544#comment-14998544
]
ASF GitHub Bot commented on FLINK-2992:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1343#discussion_r44404515
--- Diff: tools/maven/checkstyle.xml ---
@@ -54,11 +54,18 @@ under the License.
<module name="IllegalImport">
<property name="illegalPkgs"
value="org.apache.flink.shaded"/>
</module>
+ <!-- forbid use of commons lang validate -->
<module name="Regexp">
<property name="format"
value="org\.apache\.commons\.lang3\.Validate"/>
<property name="illegalPattern" value="true"/>
<property name="message" value="Use Guava Checks
instead of Commons Validate. Please refer to the coding guidelines."/>
</module>
+ <!-- forbid the use of
org.apache.commons.lang.SerializationUtils -->
+ <module name="Regexp">
+ <property name="format"
value="org\.apache\.commons\.lang\.SerializationUtils"/>
+ <property name="illegalPattern" value="true"/>
+ <property name="message" value="Use Flink's
InstantiationUtil instead of common's SerializationUtils"/>
+ </module>
<module name="NeedBraces">
--- End diff --
Doesn't that still allow to import org.apache.commons.lang.* and use
SerializationUtils afterwards? :)
> New Windowing code is using SerializationUtils with wrong classloader
> ---------------------------------------------------------------------
>
> Key: FLINK-2992
> URL: https://issues.apache.org/jira/browse/FLINK-2992
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Priority: Critical
>
> During release testing, I found the following issue
> {code}
> robert@hn0-flink0:~/flink010-26-211/flink-0.10.0$ ./bin/flink run
> ../../scratch/target/flink0.10-scala2.11-1.0-SNAPSHOT.jar --input
> hdfs:///user/robert/file.txt --out hdfs:///user/robert/result
> Found YARN properties file /tmp/.yarn-properties-robert
> Using JobManager address from YARN properties 10.0.0.5/10.0.0.5:59812
> org.apache.flink.client.program.ProgramInvocationException: The main method
> caused an error.
> at
> org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:512)
> at
> org.apache.flink.client.program.PackagedProgram.invokeInteractiveModeForExecution(PackagedProgram.java:395)
> at org.apache.flink.client.program.Client.runBlocking(Client.java:252)
> at
> org.apache.flink.client.CliFrontend.executeProgramBlocking(CliFrontend.java:675)
> at org.apache.flink.client.CliFrontend.run(CliFrontend.java:326)
> at
> org.apache.flink.client.CliFrontend.parseParameters(CliFrontend.java:977)
> at org.apache.flink.client.CliFrontend.main(CliFrontend.java:1027)
> Caused by: org.apache.commons.lang.SerializationException:
> java.lang.ClassNotFoundException: com.dataartisans.Job$$anon$3$$anon$2
> at
> org.apache.commons.lang.SerializationUtils.deserialize(SerializationUtils.java:166)
> at
> org.apache.commons.lang.SerializationUtils.deserialize(SerializationUtils.java:193)
> at
> org.apache.commons.lang.SerializationUtils.clone(SerializationUtils.java:81)
> at
> org.apache.flink.streaming.api.datastream.WindowedStream.reduce(WindowedStream.java:172)
> at
> org.apache.flink.streaming.api.scala.WindowedStream.aggregate(WindowedStream.scala:352)
> at
> org.apache.flink.streaming.api.scala.WindowedStream.aggregate(WindowedStream.scala:332)
> at
> org.apache.flink.streaming.api.scala.WindowedStream.sum(WindowedStream.scala:300)
> at com.dataartisans.Job$.main(Job.scala:59)
> at com.dataartisans.Job.main(Job.scala)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:497)
> ... 6 more
> Caused by: java.lang.ClassNotFoundException:
> com.dataartisans.Job$$anon$3$$anon$2
> at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:278)
> at java.io.ObjectInputStream.resolveClass(ObjectInputStream.java:625)
> at
> java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1612)
> at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1517)
> at
> java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1771)
> at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1350)
> at
> java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1997)
> at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1921)
> at
> java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1798)
> at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1350)
> at
> java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1997)
> at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1921)
> at
> java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1798)
> at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1350)
> at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370)
> at
> org.apache.commons.lang.SerializationUtils.deserialize(SerializationUtils.java:163)
> ... 19 more
> The exception above occurred while trying to run your command.
> {code}
> The problem is that we are using the
> org.apache.commons.lang.SerializationUtils with the wrong classloader.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
