tillrohrmann commented on a change in pull request #10513: [FLINK-15082]
Respect new FLIP-49 taskmanager.memory.total-process.size in Mesos RM
URL: https://github.com/apache/flink/pull/10513#discussion_r356499599
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
##########
@@ -422,6 +422,29 @@ private static double getCpuCores(final Configuration
configuration) {
return
TaskExecutorResourceUtils.getCpuCoresWithFallback(configuration,
fallback).getValue().doubleValue();
}
+ private static MemorySize getTotalProcessMemory(final Configuration
configuration) {
+ MemorySize legacyTotalProcessMemory =
MemorySize.parse(configuration.getInteger(MESOS_RM_TASKS_MEMORY_MB) + "m");
+ MemorySize unifiedTotalProcessMemory =
MemorySize.parse(configuration.getString(TaskManagerOptions.TOTAL_PROCESS_MEMORY,
"0"));
Review comment:
What should happen if neither of the two options are set? At the moment we
will default to the default value of `MESOS_RM_TASKS_MEMORY_MB`. Is this what
we want in the long run or should it rather fail because we want the user to
configure `TOTAL_PROCESS_MEMORY`? The implication would be to only consider
`MESOS_RM_TASKS_MEMORY_MB` if it has been explicitly set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
