[ 
https://issues.apache.org/jira/browse/FLINK-15171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993412#comment-16993412
 ] 

Roman Khachatryan commented on FLINK-15171:
-------------------------------------------

Was able to reproduce locally running just a single `serializerRow` test:
{code:java}
HEAD detached at 2ecf7cacbe
    Result 
"org.apache.flink.benchmark.SerializationFrameworkMiniBenchmarks.serializerRow":
      386.236 ±(99.9%) 13.426 ops/ms [Average]
      (min, avg, max) = (349.271, 386.236, 432.025), stdev = 20.095
HEAD detached at be967fa1f7
    Result 
"org.apache.flink.benchmark.SerializationFrameworkMiniBenchmarks.serializerRow":
      360.470 ±(99.9%) 9.693 ops/ms [Average]
      (min, avg, max) = (323.661, 360.470, 398.283), stdev = 14.507
{code}
(flink-benchmarks at d30f2b3e0bf616e857f5e47be6d6b407a2a0921e)

The difference is ~7% which matches -7.66% at 
[http://codespeed.dak8s.net:8000/changes/?rev=9320f34&exe=1&env=2]

> Performance regression in serialisation benchmarks
> --------------------------------------------------
>
>                 Key: FLINK-15171
>                 URL: https://issues.apache.org/jira/browse/FLINK-15171
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Type Serialization System, Benchmarks
>    Affects Versions: 1.10.0
>            Reporter: Piotr Nowojski
>            Assignee: Roman Khachatryan
>            Priority: Blocker
>             Fix For: 1.10.0
>
>         Attachments: dec05.svg, dec11.svg
>
>
> There is quite significant performance regression in serialisation benchmarks 
> in the commit range 2ecf7ca..9320f34 (which includes FLINK-14346).
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerTuple&env=2
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerRow&env=2
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerPojo&env=2
> it coincides with the performance improvement for heavy strings
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerHeavyString&env=2
> it might be caused by some accidental change in the benchmarking code 
> (changing parallelism in one benchmarks is carried on to the next one?) or in 
> the code itself.
> CC [~rgrebennikov] [~AHeise]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to