xintongsong commented on a change in pull request #10513: [FLINK-15082] Respect
new FLIP-49 taskmanager.memory.total-process.size in Mesos RM
URL: https://github.com/apache/flink/pull/10513#discussion_r356555185
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
##########
@@ -422,6 +422,29 @@ private static double getCpuCores(final Configuration
configuration) {
return
TaskExecutorResourceUtils.getCpuCoresWithFallback(configuration,
fallback).getValue().doubleValue();
}
+ private static MemorySize getTotalProcessMemory(final Configuration
configuration) {
+ MemorySize legacyTotalProcessMemory =
MemorySize.parse(configuration.getInteger(MESOS_RM_TASKS_MEMORY_MB) + "m");
+ MemorySize unifiedTotalProcessMemory =
MemorySize.parse(configuration.getString(TaskManagerOptions.TOTAL_PROCESS_MEMORY,
"0"));
Review comment:
IMO, from the perspective of backwards compatibility, if the new unified
`TOTAL_PROCESS_MEMORY` is not explicitly configured, we should fallback to the
legacy `MESOS_RM_TASKS_MEMORY_MB`, including fallback to its default value if
not explicitly configured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
