KurtYoung commented on a change in pull request #10523:
[FLINK-15073][sql-client] SQL-CLI fails to run same query multiple times
URL: https://github.com/apache/flink/pull/10523#discussion_r356974029
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -619,16 +619,17 @@ public ProgramTargetDescriptor executeUpdate(String
sessionId, String statement)
removeTimeAttributes(table.getSchema()),
context.getExecutionConfig(),
context.getClassLoader());
- // Job name format: "sessionId: query" with all the quotes
character removed.
- final String jobName = (sessionId + ": " +
query).replaceAll("`", "");
+ // Job name format: "sessionId: query"
Review comment:
unnecessary comment, the code is already pretty clear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
