pnowojski commented on a change in pull request #10539: [FLINK-14952][network]
Solve the issue of exceeding memory limits when using mmap blocking partition
URL: https://github.com/apache/flink/pull/10539#discussion_r357039227
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -184,12 +184,13 @@
"tasks have occupied all the buffers
and the downstream tasks are waiting for the exclusive buffers. The timeout
breaks" +
"the tie by failing the request of
exclusive buffers and ask users to increase the number of total buffers.");
- @Documentation.ExcludeFromDocumentation("This option is only used for
testing at the moment.")
public static final ConfigOption<String>
NETWORK_BOUNDED_BLOCKING_SUBPARTITION_TYPE =
key("taskmanager.network.bounded-blocking-subpartition-type")
Review comment:
rename to `taskmanager.network.blocking-shuffle.type` to unify it with the
resolution of the discussion around the compression configs? And mention that
it's experimental?
If we rename it, it should probably be mentioned in the release notes. Maybe
it was excluded from the docs, but we told about this property on the mailing
list to some users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
