twalthr commented on a change in pull request #10518: [FLINK-15124][table] Fix
types with precision defined in DDL can't be executed
URL: https://github.com/apache/flink/pull/10518#discussion_r357109050
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvTableSinkFactoryBase.java
##########
@@ -75,6 +75,8 @@
properties.add(SCHEMA + ".#." +
DescriptorProperties.TABLE_SCHEMA_TYPE);
properties.add(SCHEMA + ".#." +
DescriptorProperties.TABLE_SCHEMA_DATA_TYPE);
properties.add(SCHEMA + ".#." +
DescriptorProperties.TABLE_SCHEMA_NAME);
+ // schema watermark
+ properties.add(SCHEMA + "." + DescriptorProperties.WATERMARK +
".*");
Review comment:
side comment: at some point we need to refactor this such that not every
connector much list all properties. This is also why we introduced
`TableSourceFactory#createTableSource(org.apache.flink.table.catalog.ObjectPath,
org.apache.flink.table.catalog.CatalogTable)`
The outer layer should deal with the schema properties and the connector can
work with `CatalogTable.getTableSchema` if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
