wangyang0918 commented on a change in pull request #10528: [FLINK-15179] Kubernetes Session CLI use generic ExecutorCLI, not custom one URL: https://github.com/apache/flink/pull/10528#discussion_r357107686
########## File path: flink-dist/src/main/flink-bin/kubernetes-bin/kubernetes-session.sh ########## @@ -36,4 +36,4 @@ log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4 export FLINK_CONF_DIR -$JAVA_RUN $JVM_ARGS -classpath "$CC_CLASSPATH" $log_setting org.apache.flink.kubernetes.cli.FlinkKubernetesCustomCli "$@" +$JAVA_RUN $JVM_ARGS -classpath "$CC_CLASSPATH" $log_setting org.apache.flink.kubernetes.cli.KubernetesSessionCli "$@" Review comment: I think we need to add `-e kubernetes-session-cluster` here. So when we use `kubernetes-session.sh` to start a session cluster, we do not need to always add `-e kubernetes-session-cluster`. It is strange for users. ``` $JAVA_RUN $JVM_ARGS -classpath "$CC_CLASSPATH" $log_setting org.apache.flink.kubernetes.cli.KubernetesSessionCli "-e" "kubernetes-session-cluster" "$@" ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
