wuchong commented on a change in pull request #10563: [FLINK-15232][table]
Message of NoMatchingTableFactoryException should tell users what's wrong
URL: https://github.com/apache/flink/pull/10563#discussion_r357546560
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/TableFactoryService.java
##########
@@ -255,10 +256,11 @@
private static <T extends TableFactory> List<T> filterByContext(
Class<T> factoryClass,
Map<String, String> properties,
- List<TableFactory> foundFactories,
List<T> classFactories) {
- List<T> matchingFactories =
classFactories.stream().filter(factory -> {
+ List<T> matchingFactories = new ArrayList<>();
+ Tuple3<T, Integer, Map<String, Tuple2<String, String>>>
bestMatched = null;
Review comment:
Could you create a inner class to encapsulate the matched information? It's
really hard to guess what does every part mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
