leonardBang commented on a change in pull request #10536:
[FLINK-15191][connectors / kafka]Fix can't create table source for Kafka if
watermark or computed column is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r357615299
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/descriptors/SchemaValidator.java
##########
@@ -89,6 +95,13 @@ public void validate(DescriptorProperties properties) {
properties.validateString(SCHEMA + "." + i + "." +
SCHEMA_NAME, false, 1);
properties.validateDataType(SCHEMA + "." + i + "." +
SCHEMA_DATA_TYPE, SCHEMA + "." + i + "." + SCHEMA_TYPE, false);
properties.validateString(SCHEMA + "." + i + "." +
SCHEMA_FROM, true, 1);
+
+ // validate generated column expression
+ final String generatedColumnExpressionKey = SCHEMA +
"." + i + "." + TABLE_SCHEMA_EXPR;
+ if
(properties.containsKey(generatedColumnExpressionKey)) {
+
properties.validateString(generatedColumnExpressionKey, false, 1);
+ }
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
