zentol commented on a change in pull request #10544: [FLINK-13567][e2e] Harden
schema registry test
URL: https://github.com/apache/flink/pull/10544#discussion_r357632117
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -143,7 +146,7 @@ function start_confluent_schema_registry {
if ! get_and_verify_schema_subjects_exist; then
echo "Could not start confluent schema registry"
- exit 1
+ return 1
Review comment:
Yes previously it would exit immediately but that makes it impossible to
introduce any retry behavior. (well I suppose a sub-shell might work)
The exit code of test_confluent_schema_registry#test_setup is implicitly the
return value of #start_confluent_schema_registry, and hence is evaluated by the
retry loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
