zhuzhurk commented on a change in pull request #10541: [FLINK-15169][runtime]
Set failures happen in DefaultScheduler to ExecutionGraph/Execution to make
them visible to REST
URL: https://github.com/apache/flink/pull/10541#discussion_r357691119
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionVertexOperations.java
##########
@@ -35,4 +35,9 @@ public void deploy(final ExecutionVertex executionVertex)
throws JobException {
public CompletableFuture<?> cancel(final ExecutionVertex
executionVertex) {
return executionVertex.cancel();
}
+
+ @Override
+ public void markFailed(final ExecutionVertex executionVertex, final
Throwable cause) {
+ executionVertex.markFailed(cause);
Review comment:
Yes. And that's why I had wanted to do FLINK-14606 to use a
`isInternalError` flag to supersede `fromSchedulerNg`.
I think we can simplify it after the legacy scheduler is removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
