pnowojski commented on issue #10529: [FLINK-15171] [serialization] fix performance regression caused by too many buffer allocations on string serialization URL: https://github.com/apache/flink/pull/10529#issuecomment-566141171 One more thing > most of the char[] allocations come from the readString method: we are allocating a temp buffer to decode characters to, and then the String constructor makes a deep copy of this buffer. Actually there is no need to allocate this buffer on every invocation, we can do the same trick with buffer reuse. Yes, I've seen it, as far as I can tell, you haven't increased the amount of `char[]` allocations. But from the data you presented, it looks like you did? Or the number of allocations before/after regression was from two samples of a different length/duration? If that's the case, I struggle to understand, why there is still a performance regression for small strings with this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
