bowenli86 commented on a change in pull request #10578: [FLINK-15254][sql
cli][module] modules in SQL CLI yaml should preserve order
URL: https://github.com/apache/flink/pull/10578#discussion_r358400431
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
##########
@@ -69,7 +69,7 @@
private DeploymentEntry deployment;
public Environment() {
- this.modules = Collections.emptyMap();
+ this.modules = new LinkedHashMap<>();
Review comment:
we'd better use a linked hashmap to preserve order just in case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
