AHeise commented on a change in pull request #10567: [FLINK-15244][FileSystems] 
Fix the bug that FileUtils#deleteDirectoryInternal will delete files in the 
symbolic link which point to a directory.
URL: https://github.com/apache/flink/pull/10567#discussion_r358675283
 
 

 ##########
 File path: flink-core/src/test/java/org/apache/flink/util/FileUtilsTest.java
 ##########
 @@ -202,6 +202,24 @@ public void testDeleteDirectoryWhichIsAFile() throws 
Exception {
                }
        }
 
+       @Test
+       public void testDeleteSymbolicLinkDirectory() throws Exception {
 
 Review comment:
   👍  I like the test setup, very concise and tests the relevant part!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to