tillrohrmann commented on a change in pull request #10571: [FLINK-15241] Revert
the unexpected change of the configuration for M…
URL: https://github.com/apache/flink/pull/10571#discussion_r358911492
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -570,7 +570,7 @@ private static CPUResource getCpuCores(final Configuration
config, double fallba
if (cpuCores < 0) {
throw new
IllegalConfigurationException("Configured cpu cores must be non-negative.");
}
- } else if (fallback >= 0.0) {
Review comment:
All right, but then we should also update the other branches of this if
statement. More concretely, we need to also throw an
`IllegalConfigurationException` if `cpuCores == 0`. And we should check that
`config.getInteger(TaskManagerOptions.NUM_TASK_SLOTS)` returns `> 0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
