tillrohrmann commented on a change in pull request #10532:
[FLINK-15053][runtime] Escape all dynamical property values for taskmanager
URL: https://github.com/apache/flink/pull/10532#discussion_r360343511
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -621,23 +621,38 @@ public Config getAkkaConfig() {
*
* @param baseConfig The base configuration.
* @param targetConfig The target configuration.
- * @return Dynamic properties as string, separated by whitespace.
+ * @return Dynamic properties as string array.
*/
- public static String getDynamicProperties(Configuration baseConfig,
Configuration targetConfig) {
+ public static String[] getDynamicProperties(Configuration baseConfig,
Configuration targetConfig) {
Review comment:
As said above, I would keep the contract of this method as moving the
responsibility of generating the final string into the `ResourceManagers`
duplicates logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
