KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times URL: https://github.com/apache/flink/pull/10657#issuecomment-568454203 > Quick question, isn't the problem that we pass the `command` in [cce1cef](https://github.com/apache/flink/commit/cce1cef50d993aba5060ea5ac597174525ae895e) as multiple strings instead of wrapping the command in `""` before we pass it to `retry_times`? If I look at `retry_times_with_backoff_and_cleanup` then one also needs to pass the `command` and `cleanup_command` as a single string (meaning one needs to wrap it into `""`). The fix seems to underline this as we are joining `${@:3}` into a single string. > > The problem now is that `retry_times` and `retry_times_with_backoff_and_cleanup` behave differently wrt their parameters. Before [bdd432](https://github.com/apache/flink/commit/bdd432a09a776fec88f465771101893a8151dc1d), `retry_times` will joining `${@:3}` into a single string. So, I think that commit changes the contract of `retry_times`, not as excepted. This PR fix that problem. Regarding to the inconsistent parameter, I agreed it's better to align the behavior of two functions. We could work on it in future work. WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
