Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1355#issuecomment-156859098
Thanks for the interest in helping us maintain clear code.
I think actually that the original code was easier than the code with
counter checks. Further more, it moves branches away from loops (easier
optimizable by the JIT compiler). Finally, the new code will be wrong if the
counter overflows/wraps around, which is not unthinkable. 4 Billion elements is
quite within the scope of many applications.
I am curious about other opinions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
