wuchong commented on a change in pull request #10667: [FLINK-15313][table] Fix
can't insert decimal data into sink using TypeInformation
URL: https://github.com/apache/flink/pull/10667#discussion_r361289645
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/MiniBatchIntervalInferTest.xml
##########
@@ -222,7 +222,7 @@ LogicalProject(a=[$0], b=[$1])
<Resource name="planAfter">
<![CDATA[
Calc(select=[a, b])
-+- Join(joinType=[InnerJoin], where=[=(a0, a1)], select=[a, b, a0, b0, a1],
leftInputSpec=[HasUniqueKey], rightInputSpec=[HasUniqueKey])
++- Join(joinType=[InnerJoin], where=[=(a0, a1)], select=[a, b, a0, b0, a1],
leftInputSpec=[JoinKeyContainsUniqueKey], rightInputSpec=[HasUniqueKey])
Review comment:
`JoinKeyContainsUniqueKey` is correct, because `a` is the group by key of
left stream and also the join field. And `a` is an int type, `cast(a as
bigint)` doesn't lose information so that it keeps the unique key information
of left stream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
