wuchong commented on a change in pull request #10680:
[FLINK-15125][table-planner-blink] PROCTIME() computed column defined…
URL: https://github.com/apache/flink/pull/10680#discussion_r361300927
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -655,8 +660,7 @@ class CatalogTableITCase(isStreamingMode: Boolean) extends
AbstractTestBase {
|create table t1(
| a int,
| b int,
- | c as proctime,
- | primary key(a)
+ | c as proctime()
Review comment:
This test is not stable even if we sleep 1s or more in the source. The
source may finish before window is triggered when the cpu load of machine is
high.
Actually, we don't add integration tests for processing time windows. We can
add harness tests for processing time operators (e.g. `OverWindowHarnessTest`).
In this PR, I think we can just add unit tests for plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
