docete opened a new pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest… URL: https://github.com/apache/flink/pull/10722 …ampMinAggFunction to accept SqlTimestamp values ## What is the purpose of the change The `MaxWithRetractAggFunction`/`MinWithRetractAggFunction` in blink planner not support "accumulate(acc, Object value)" generic object with third-part data formats. We only support internal/external format in this usage. In this PR, we use SqlTimestamp(the internal format of TimestampType) in `TimestampMaxAggFunction`/`TimestampMinAggFunction` to fix the `ClassCastException` ## Brief change log - 5a8613d use SqlTimestamp in `TimestampMaxAggFunction` and `TimestampMinAggFunction` ## Verifying this change This change added tests ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (**yes** / no) - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
