wuchong commented on a change in pull request #10714: [FLINK-15409]Add
semicolon after WindowJoinUtil#generateJoinFunction
'$collectorTerm.collect($joinedRow)' statement
URL: https://github.com/apache/flink/pull/10714#discussion_r362144456
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/WindowJoinTest.scala
##########
@@ -418,6 +421,20 @@ class WindowJoinTest extends TableTestBase {
">($2, $6)")
}
+ @Test
+ def testJoinFunctionGenerate(): Unit ={
Review comment:
Please remove this test. `WindowJoinTest` is used to verify plans. Tests for
code generation should not be put in this class. And IMO, this test doesn't
reproduce the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
