[
https://issues.apache.org/jira/browse/FLINK-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008516#comment-15008516
]
ASF GitHub Bot commented on FLINK-2914:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1359#issuecomment-157343610
Looks correct (and affects only logging).
Will merge this...
> Missing break in
> ZooKeeperSubmittedJobGraphStore#SubmittedJobGraphsPathCacheListener#childEvent()
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-2914
> URL: https://issues.apache.org/jira/browse/FLINK-2914
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chesnay Schepler
> Priority: Minor
>
> {code}
> case CONNECTION_SUSPENDED:
> LOG.warn("ZooKeeper connection SUSPENDED. Changes to the submitted
> job " +
> "graphs are not monitored (temporarily).");
> case CONNECTION_LOST:
> LOG.warn("ZooKeeper connection LOST. Changes to the submitted job "
> +
> "graphs are not monitored (permanently).");
> break;
> case CONNECTION_RECONNECTED:
> LOG.info("ZooKeeper connection RECONNECTED. Changes to the
> submitted job " +
> "graphs are monitored again.");
> case INITIALIZED:
> LOG.info("SubmittedJobGraphsPathCacheListener initialized");
> break;
> {code}
> For CONNECTION_SUSPENDED and CONNECTION_RECONNECTED, the break statement is
> missing.
> This would result in unrelated event logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
