wangyang0918 commented on a change in pull request #10728: [FLINK-15437][yarn]
Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#discussion_r362416234
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1045,10 +1031,6 @@ private ApplicationReport startAppMaster(
appMasterEnv.put(YarnConfigKeys.ENV_KRB5_PATH,
remoteKrb5Path.toString());
}
- if (dynamicPropertiesEncoded != null) {
Review comment:
Since we have apply all the dynamic properties to the client uploaded flink
configuration, so we will not need to set the `ENV_DYNAMIC_PROPERTIES` and
parse it in the jobmanager. So `YarnConfigKeys.ENV_DYNAMIC_PROPERTIES` could be
removed and all the usage on the jobmanager side should also be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
