rkhachatryan commented on a change in pull request #10151: [FLINK-14231] Handle
the pending processing-time timers to make endInput semantics on the operator
chain strict
URL: https://github.com/apache/flink/pull/10151#discussion_r362467858
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -521,14 +521,14 @@ private void runMailboxLoop() throws Exception {
private void afterInvoke() throws Exception {
LOG.debug("Finished task {}", getName());
+ // close all operators in a chain effect way. closing happens
from head to tail
+ // operator in the chain, contrary to StreamOperator#open()
which happens tail to head.
+ // (see #initializeStateAndOpen()).
+ operatorChain.getHeadOperatorWrapper().close(this, true);
Review comment:
We're passing `StreamTask.this` here to only synchronize on its
`checkpointLock`, which was deprecated.
Can we pass and use `actionExecutor` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
