tillrohrmann commented on a change in pull request #10717:
[FLINK-15369][runtime] MiniCluster use fixed network / managed memory sizes by
default
URL: https://github.com/apache/flink/pull/10717#discussion_r362773234
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterConfigurationTest.java
##########
@@ -74,4 +77,12 @@ public void
testSchedulerType_notOverriddenIfExistingInConfig() {
JobManagerOptions.SCHEDULER.defaultValue(),
miniClusterConfiguration.getConfiguration().getString(JobManagerOptions.SCHEDULER));
}
+
+ @Test
+ public void testDefaultTaskExecutorMemoryConfiguration() {
+ final MiniClusterConfiguration miniClusterConfiguration = new
MiniClusterConfiguration.Builder().build();
+
+
assertTrue(TaskExecutorResourceUtils.isManagedMemorySizeExplicitlyConfigured(miniClusterConfiguration.getConfiguration()));
+
assertTrue(TaskExecutorResourceUtils.isShuffleMemoryExplicitlyConfigured(miniClusterConfiguration.getConfiguration()));
Review comment:
This test confused me first a bit because it seems strange that the memory
is explicitly configured as we say we wanna use the defaults. I think it would
be easier to understand if we simply assert the exact managed and network
memory settings derived from the `Configuration`.
One should first extract the defaults and store them in some static
variables from `adjustConfigurationForLocalExecution`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
