tillrohrmann commented on a change in pull request #10532:
[FLINK-15053][runtime] Escape all dynamical property values for taskmanager
URL: https://github.com/apache/flink/pull/10532#discussion_r362808110
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -642,6 +654,35 @@ public static String getDynamicProperties(Configuration
baseConfig, Configuratio
return String.join(" ", newAddedConfigs);
}
+ /**
+ * Escape all the dynamic property values.
+ * For unix-like OS(Linux, MacOS, FREE_BSD, etc.), each value will be
surrounded with single quotes. This works for
+ * all chars except single quote itself. To escape the single quote,
close the quoting before it, insert the escaped
+ * single quote, and then re-open the quoting. For example, the value
is foo'bar and the escaped value is
+ * 'foo'\''bar'.
Review comment:
Would be good to add the stackoverflow reference for how we escape strings
for Unix like systems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
