tillrohrmann commented on a change in pull request #10608:
[FLINK-15300][Runtime] Fix sanity check to not fail if shuffle memory fraction
is out of min/max range
URL: https://github.com/apache/flink/pull/10608#discussion_r362810812
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -607,8 +610,8 @@ private static TaskExecutorResourceSpec
createTaskExecutorResourceSpec(
this.minSize = minSize;
this.maxSize = maxSize;
this.fraction = fraction;
- checkArgument(minSize.getBytes() <= maxSize.getBytes());
- checkArgument(fraction >= 0 && fraction <= 1);
+ checkArgument(minSize.getBytes() <= maxSize.getBytes(),
"min value must be less or equal to max value");
+ checkArgument(fraction >= 0 && fraction < 1, "fraction
must be in range [0, 1)");
Review comment:
Why does the range needs to be exclusive of `1`? I would assume that
`fraction == 1` is a valid value of the `RangeFraction`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
