carp84 commented on a change in pull request #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r362846562
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write
rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED =
ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Track whether write has been stopped in
RocksDB. Returns 1 if write has been stopped, 0 otherwise.");
Review comment:
IMO it could help understand the data of this metrics and how to
monitor/read it, following the same pattern as
[RocksDBProperty.CompactionPending](https://github.com/apache/flink/blob/65853b375abd1e6b3d2b9c7734d7f93aa5d529a0/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java#L57)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
