tillrohrmann commented on a change in pull request #10682:
[FLINK-15247][Runtime] Wait for all slots to be free before task executor
services shutdown upon stopping
URL: https://github.com/apache/flink/pull/10682#discussion_r362847991
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -731,70 +697,6 @@ public void invoke() throws Exception {
}
}
- @Test
- public void testTaskInterruptionAndTerminationOnShutdown() throws
Exception {
Review comment:
By removing this test we lose coverage that we don't stop the `TaskExecutor`
before all tasks have been terminated. I couldn't find another test testing
this scenario. Hence, please add one or revert the removal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
